Re: [PATCH] selinux: Use 1UL for EBITMAP_BIT to match maps type
From: Paul Moore
Date: Tue Jul 02 2024 - 11:41:15 EST
On Jun 29, 2024 Canfeng Guo <guocanfeng@xxxxxxxxxxxxx> wrote:
>
> This patch modifies the definition of EBITMAP_BIT in
> security/selinux/ss/ebitmap.h from 1ULL to 1UL to match the type
> of elements in the ebitmap_node maps array.
>
> This change does not affect the functionality or correctness of
> the code but aims to enhance code quality by adhering to good
> programming practices and avoiding unnecessary type conversions.
>
> Signed-off-by: Canfeng Guo <guocanfeng@xxxxxxxxxxxxx>
> ---
> security/selinux/ss/ebitmap.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, this looks good to me, and it's trivial enough that I think it
is safe to merge at this point in the release cycle; merged to
selinux/dev.
--
paul-moore.com