Re: [PATCH v2 -next] cgroup/rstat: add force idle show helper

[Tejun Heo]

Hello,

On Tue, Jul 02, 2024 at 02:28:22AM +0000, Chen Ridong wrote:
...
>  	if (cgroup_parent(cgrp)) {
>  		cgroup_rstat_flush_hold(cgrp);
>  		usage = cgrp->bstat.cputime.sum_exec_runtime;
>  		cputime_adjust(&cgrp->bstat.cputime, &cgrp->prev_cputime,
>  			       &utime, &stime);
> -#ifdef CONFIG_SCHED_CORE
> -		forceidle_time = cgrp->bstat.forceidle_sum;
> -#endif
> +		bstat = cgrp->bstat;

Please don't copy non-trivial struct like this. Maybe add a pointer which
points to the bstat to use?

Thanks.

-- 
tejun