Re: [PATCH v23 14/19] x86/resctrl: Handle removing directories in Sub-NUMA Cluster (SNC) mode

From: Borislav Petkov
Date: Tue Jul 02 2024 - 13:28:55 EST


On Tue, Jul 02, 2024 at 10:16:39AM -0700, Tony Luck wrote:
> A helper will avoid this duplication. Draft below. Is this
> what you want?

Yap, looks good.

> Is the function name OK. I wasn't sure if the
> "mon" looked better at the beginning. Or as rmdir_one_mon_subdir()

It's a static function so the namespace doesn't matter that much, I'd say.

> I've also fixed up part 17 to use msr_clear_bit()

Good.

> Are you still digging through the patches?

Yap, and you can send me only those two which you've modified and I'll
integrate them with the rest and queue them.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette