Re: [PATCH] filelock: fix potential use-after-free in posix_lock_inode
From: Alexander Aring
Date: Tue Jul 02 2024 - 21:19:59 EST
Hi,
On Tue, Jul 2, 2024 at 6:45 PM Jeff Layton <jlayton@xxxxxxxxxx> wrote:
>
> Light Hsieh reported a KASAN UAF warning in trace_posix_lock_inode().
> The request pointer had been changed earlier to point to a lock entry
> that was added to the inode's list. However, before the tracepoint could
> fire, another task raced in and freed that lock.
>
> Fix this by moving the tracepoint inside the spinlock, which should
> ensure that this doesn't happen.
>
makes sense to me. Thanks.
Reviewed-by: Alexander Aring <aahringo@xxxxxxxxxx>
- Alex