Re: [PATCH 2/3] modpost: .meminit.* is not in init section when CONFIG_MEMORY_HOTPLUG set

From: Andrew Morton
Date: Tue Jul 02 2024 - 21:52:42 EST


On Tue, 2 Jul 2024 23:40:07 +0000 Wei Yang <richard.weiyang@xxxxxxxxx> wrote:

> .meminit.* is not put into init section when CONFIG_MEMORY_HOTPLUG is
> set, since we define MEM_KEEP()/MEM_DISCARD() according to
> CONFIG_MEMORY_HOTPLUG.

Please describe how this changes modpost behaviour.

Something like: "we're currently not checking for references into
meminit and meminitdata when CONFIG_HOTPLUG=y, which may cause us to
fail to notice incorrect references.". But I don't think that's
correct. So what *is* wrong with the current code?