Re: [PATCH 1/3] scsi: sd: disable discard when set target full provisioning

[Martin K. Petersen]

Haoqian,

> +	if (!sdkp->lbpvpd)
> +		/* Disable discard if LBP VPD page not provided */
> +		return SD_LBP_DISABLE;

That is not a valid assumption. Many devices which support thin
provisioning either predate the LBP VPD being defined or have decided
not to support that page. The current heuristics are very deliberate.

-- 
Martin K. Petersen	Oracle Linux Engineering