RE: [PATCH v5 3/6] dt-bindings: iio: dac: Generalize DAC common properties

[Paller, Kim Seer]

> -----Original Message-----
> From: Conor Dooley <conor@xxxxxxxxxx>
> Sent: Tuesday, July 2, 2024 11:30 PM
> To: Paller, Kim Seer <KimSeer.Paller@xxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; Jonathan Cameron <jic23@xxxxxxxxxx>; David
> Lechner <dlechner@xxxxxxxxxxxx>; Lars-Peter Clausen <lars@xxxxxxxxxx>;
> Liam Girdwood <lgirdwood@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>;
> Dimitri Fedrau <dima.fedrau@xxxxxxxxx>; Krzysztof Kozlowski
> <krzk+dt@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>; Hennerich, Michael
> <Michael.Hennerich@xxxxxxxxxx>; Nuno Sá <noname.nuno@xxxxxxxxx>
> Subject: Re: [PATCH v5 3/6] dt-bindings: iio: dac: Generalize DAC common
> properties
> 
> [External]
> 
> On Tue, Jul 02, 2024 at 11:00:22AM +0800, Kim Seer Paller wrote:
> > Introduce a generalized DAC binding that can be used by DACs that have
> > similar properties adding output-range-microamp and output-range-
> microvolt.
> >
> > Signed-off-by: Kim Seer Paller <kimseer.paller@xxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/iio/dac/dac.yaml      | 50 +++++++++++++++++++
> >  1 file changed, 50 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/dac/dac.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/dac/dac.yaml
> > b/Documentation/devicetree/bindings/iio/dac/dac.yaml
> > new file mode 100644
> > index 000000000000..579f52ea6eb1
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/dac/dac.yaml
> > @@ -0,0 +1,50 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/dac/dac.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: IIO Common Properties for DAC Channels
> > +
> > +maintainers:
> > +  - Jonathan Cameron <jic23@xxxxxxxxxx>
> > +
> > +description:
> > +  A few properties are defined in a common way DAC channels.
> 
> "for DAC channels"
> 
> > +anyOf:
> > +  - oneOf:
> > +      - required:
> > +          - reg
> > +          - output-range-microamp
> > +      - required:
> > +          - reg
> > +          - output-range-microvolt
> > +  - required:
> > +      - reg
> 
> Can't this be more simply written as
> 
> oneOf:
>   - required:
>       - output-range-microamp
>   - required:
>       - output-range-microvolt
> 
> required:
>  - reg
> 
>  ?

I was following the structure used in adc.yaml.
Yes, I think we can simplify it with that.