Re: [PATCH 3/7] dt-bindings: gpio: vf610: Allow gpio-line-names to be set

From: Frieder Schrempf
Date: Wed Jul 03 2024 - 03:43:43 EST


Hi Krzysztof,

thanks for reviewing!

On 02.07.24 4:23 PM, Krzysztof Kozlowski wrote:
> On 02/07/2024 12:31, Frieder Schrempf wrote:
>> From: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
>>
>> Describe common "gpio-line-names" property to fix dtbs_check warnings
>> like:
>>
>> arch/arm64/boot/dts/freescale/imx93-kontron-bl-osm-s.dtb: gpio@43810000:
>
> There is no such file. You cannot use future work as reason for a
> warning. Simply such warning does not exist at this point and
> introducing warnings knowingly is also not correct.

Ok, I will change the commit message and not mention the warning.

>
>> 'gpio-line-names' does not match any of the regexes: '^.+-hog(-[0-9]+)?$', 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>
>> ---
>> Documentation/devicetree/bindings/gpio/gpio-vf610.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
>> index a27f929502575..7230ba1a386ae 100644
>> --- a/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
>> +++ b/Documentation/devicetree/bindings/gpio/gpio-vf610.yaml
>> @@ -50,6 +50,7 @@ properties:
>> const: 2
>>
>> gpio-controller: true
>> + gpio-line-names: true
>
> maxItems are not known?

I will set "minItems: 1" and "maxItems: 32" as this is the proper range
for the number of values.

Thanks
Frieder