Re: [PATCH v3] PCI: hv: Return zero, not garbage, when reading PCI_INTERRUPT_PIN
From: Krzysztof Wilczyński
Date: Wed Jul 03 2024 - 04:12:59 EST
Hello,
> > The intent of the code snippet is to always return 0 for both
> > PCI_INTERRUPT_LINE and PCI_INTERRUPT_PIN.
> >
> > The check misses PCI_INTERRUPT_PIN. This patch fixes that.
> >
> > This is discovered by this call in VFIO:
> >
> > pci_read_config_byte(vdev->pdev, PCI_INTERRUPT_PIN, &pin);
> >
> > The old code does not set *val to 0 because it misses the check for
> > PCI_INTERRUPT_PIN. Garbage is returned in that case.
[...]
>
> Bjorn & other PCI maintainers, do you want to pick this up via your
> tree?
>
> I can pick this up via the hyperv tree if you prefer.
We will pick this up. No worries.
Krzysztof