Re: [RESEND. PATCH] nvme/pci: Add APST quirk for Lenovo N60z laptop

From: WangYuli
Date: Wed Jul 03 2024 - 06:05:27 EST



On 2024/6/25 05:49, Keith Busch wrote:
Based on your commit message, it sounds like the platform works the
majority of the time. Is it possible that NVME_QUIRK_NO_DEEPEST_PS is
sufficient for this? Or do you really need to disable it entirely? The
power usage differences can be meaningful.

Also, 30 minutes of idle is an eternity for APST to kick in, so I'm
curious if there's something else going on here or if the breakage
occurs earlier than that.

When we "quiesce" a machine, some applications may not stop disk I/O promptly,
so the 30 minutes include the time to wait for these background processes to quiet down.

Thanks for the reminder. I've tested it and 'NVME_QUIRK_NO_DEEPEST_PS' is effective and
more appropriate than 'NVME_QUIRK_NO_APST'. I'll send a patch v2 to update my code.

--
WangYuli <wangyuli@xxxxxxxxxxxxx>