Re: [PATCH 2/3] x86/acpi: Replace manual page table initialization with kernel_ident_mapping_init()

From: Huang, Kai
Date: Wed Jul 03 2024 - 06:23:18 EST


On Mon, 2024-07-01 at 15:43 +0300, Kirill A. Shutemov wrote:
> The function init_transition_pgtable() maps the page with
> asm_acpi_mp_play_dead() into an identity mapping.
>
> Replace manual page table initialization with kernel_ident_mapping_init()
> to avoid code duplicatiion. 
>

duplicatiion -> duplication.


> Use x86_mapping_info::offset to get the page
> is mapped at the correct location.

I don't think the "is" is needed. Just "... get the page mapped at ...".

>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>

Reviewed-by: Kai Huang <kai.huang@xxxxxxxxx>