Re: [PATCH v1 2/2] drm/panel: jd9365da: Support for Melfas lmfbx101117480 MIPI-DSI panel

[Linus Walleij]

On Tue, Jul 2, 2024 at 3:02 PM Cong Yang
<yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> The Melfas lmfbx101117480 is a 10.1" WXGA TFT-LCD panel, use jd9365da
> controller, which fits in nicely with the existing panel-jadard-jd9365da-h3
> driver. Hence, we add a new compatible with panel specific config.
>
> Signed-off-by: Cong Yang <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>

This is certainly OK
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

> +static int melfas_lmfbx101117480_init_cmds(struct jadard *jadard)
> +{
> +       struct mipi_dsi_multi_context dsi_ctx = { .dsi = jadard->dsi };
> +
> +       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe0, 0x00);
> +       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe1, 0x93);
> +       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe2, 0x65);
> +       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe3, 0xf8);
> +       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x80, 0x03);
> +       mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xe0, 0x01);

Until this point *all* displays have the same init sequence, what about
a follow-up patch that start to break things that are always the
same into helper functions?

These sequences all have a lot of the same magic bytes, so if
you guys have a datasheet for this display controller then start
adding gradually some #defines for the e0, e1, e2 etc commands
please.

Yours,
Linus Walleij