Re: [PATCH net v1 2/2] net: phy: microchip: lan87xx: do not report SQI if no link
From: Michal Kubiak
Date: Wed Jul 03 2024 - 10:01:42 EST
On Wed, Jul 03, 2024 at 03:28:01PM +0200, Oleksij Rempel wrote:
> Do not report SQI if no link is detected. Otherwise ethtool will show
> non zero value even if no cable is attached.
>
> Fixes: b649695248b15 ("net: phy: LAN87xx: add ethtool SQI support")
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> ---
> drivers/net/phy/microchip_t1.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/phy/microchip_t1.c b/drivers/net/phy/microchip_t1.c
> index a35528497a576..22530a5b76365 100644
> --- a/drivers/net/phy/microchip_t1.c
> +++ b/drivers/net/phy/microchip_t1.c
> @@ -840,6 +840,9 @@ static int lan87xx_get_sqi(struct phy_device *phydev)
> u8 sqi_value = 0;
> int rc;
>
> + if (!phydev->link)
> + return 0;
> +
> rc = access_ereg(phydev, PHYACC_ATTR_MODE_WRITE,
> PHYACC_ATTR_BANK_DSP, T1_COEF_RW_CTL_CFG, 0x0301);
> if (rc < 0)
> --
> 2.39.2
>
>
Thanks,
Reviewed-by: Michal Kubiak <michal.kubiak@xxxxxxxxx>