Re: [PATCH v5 15/27] dt-bindings: interrupt-controller: Document the property microchip,nr-irqs

From: Conor Dooley
Date: Wed Jul 03 2024 - 11:41:52 EST


On Wed, Jul 03, 2024 at 03:58:14PM +0530, Varshini Rajendran wrote:
> Add the description and conditions to the device tree documentation
> for the property microchip,nr-irqs.
>
> Signed-off-by: Varshini Rajendran <varshini.rajendran@xxxxxxxxxxxxx>

This needs to be part of patch 14.

> ---
> .../bindings/interrupt-controller/atmel,aic.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml
> index 9c5af9dbcb6e..06e5f92e7d53 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml
> @@ -54,6 +54,10 @@ properties:
> $ref: /schemas/types.yaml#/definitions/uint32-array
> description: u32 array of external irqs.
>
> + microchip,nr-irqs:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + description: u32 array of nr_irqs.

This makes no sense, did you just copy from above? Why would the number
of irqs be an array? Why can't you determine this from the compatble?

Thanks,
Conor.

> +
> allOf:
> - $ref: /schemas/interrupt-controller.yaml#
> - if:
> @@ -71,6 +75,14 @@ allOf:
> atmel,external-irqs:
> minItems: 1
> maxItems: 1
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: microchip,sam9x7-aic
> + then:
> + required:
> + - microchip,nr-irqs
>
> required:
> - compatible
> --
> 2.25.1
>

Attachment: signature.asc
Description: PGP signature