RE: [EXTERNAL] Re: [PATCH v9 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K DPI administrative driver
From: Vamsi Krishna Attunuru
Date: Wed Jul 03 2024 - 12:31:01 EST
>-----Original Message-----
>From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
>Sent: Wednesday, July 3, 2024 8:03 PM
>To: Vamsi Krishna Attunuru <vattunuru@xxxxxxxxxxx>
>Cc: arnd@xxxxxxxx; Jerin Jacob <jerinj@xxxxxxxxxxx>; Srujana Challa
><schalla@xxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
>Subject: [EXTERNAL] Re: [PATCH v9 1/1] misc: mrvl-cn10k-dpi: add Octeon
>CN10K DPI administrative driver
>
>On Wed, Jun 19, 2024 at 06: 21: 09AM -0700, Vamsi Attunuru wrote: > +struct
>dpi_mps_mrrs_cfg { > + __u16 max_read_req_sz; /* Max read request size */
>> + __u16 max_payload_sz; /* Max payload size */ > + __u16 port; /* Ebus
>port */
>On Wed, Jun 19, 2024 at 06:21:09AM -0700, Vamsi Attunuru wrote:
>> +struct dpi_mps_mrrs_cfg {
>> + __u16 max_read_req_sz; /* Max read request size */
>> + __u16 max_payload_sz; /* Max payload size */
>> + __u16 port; /* Ebus port */
>> + __u16 rsvd; /* Reserved */
>
>Please spell out "reserved" you have plenty of characters to use.
>
>Anyway, you NEVER check this, so you just made it so it can never be used.
>Please read the documentation in the kernel for how to add new ioctls, it goes
>through the reasoning why you must check this for 0 now.
Thanks for the comment, I presumed the reasoning is mainly for the copy to use space direction.
I will rename it & add the required checks to avoid any info leak.
Regards
Vamsi
>
>thanks,
>
>greg k-h