Re: [PATCH net-next v22 01/13] rtase: Add support for a pci table in this module

[Simon Horman]

On Tue, Jul 02, 2024 at 05:48:29PM +0100, Simon Horman wrote:
> On Mon, Jul 01, 2024 at 07:53:51PM +0800, Justin Lai wrote:
> > Add support for a pci table in this module, and implement pci_driver
> > function to initialize this driver, remove this driver, or shutdown
> > this driver.
> > 
> > Signed-off-by: Justin Lai <justinlai0215@xxxxxxxxxxx>
> > ---
> >  drivers/net/ethernet/realtek/rtase/rtase.h    | 338 ++++++++++
> >  .../net/ethernet/realtek/rtase/rtase_main.c   | 638 ++++++++++++++++++
> >  2 files changed, 976 insertions(+)
> >  create mode 100755 drivers/net/ethernet/realtek/rtase/rtase.h
> >  create mode 100755 drivers/net/ethernet/realtek/rtase/rtase_main.c
> > 
> > diff --git a/drivers/net/ethernet/realtek/rtase/rtase.h b/drivers/net/ethernet/realtek/rtase/rtase.h
> > new file mode 100755
> 
> nit: Source files should not have the execute bit(s) set.
> 
>      Flagged by Checkpatch.
> 
> Otherwise, this patch looks good to me.

FTR:

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>