Re: [PATCHv2 bpf-next 5/9] libbpf: Add uprobe session attach type names to attach_type_name

From: Jiri Olsa
Date: Wed Jul 03 2024 - 13:16:03 EST


On Tue, Jul 02, 2024 at 02:56:34PM -0700, Andrii Nakryiko wrote:
> On Mon, Jul 1, 2024 at 9:43 AM Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> >
> > Adding uprobe session attach type name to attach_type_name,
> > so libbpf_bpf_attach_type_str returns proper string name for
> > BPF_TRACE_UPROBE_SESSION attach type.
> >
> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> > ---
> > tools/lib/bpf/libbpf.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
>
> Can you merge this into a patch that adds BPF_TRACE_UPROBE_SESSION to
> keep bisectability of BPF selftests? It's a trivial patch, so
> shouldn't be a big deal.

ok

jirka

>
> > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> > index 492a8eb4d047..e69a54264580 100644
> > --- a/tools/lib/bpf/libbpf.c
> > +++ b/tools/lib/bpf/libbpf.c
> > @@ -133,6 +133,7 @@ static const char * const attach_type_name[] = {
> > [BPF_NETKIT_PRIMARY] = "netkit_primary",
> > [BPF_NETKIT_PEER] = "netkit_peer",
> > [BPF_TRACE_KPROBE_SESSION] = "trace_kprobe_session",
> > + [BPF_TRACE_UPROBE_SESSION] = "trace_uprobe_session",
> > };
> >
> > static const char * const link_type_name[] = {
> > --
> > 2.45.2
> >