Re: [PATCH 0/7] dm-verity cleanups and optimizations

From: Eric Biggers
Date: Wed Jul 03 2024 - 15:15:57 EST


On Mon, Jul 01, 2024 at 11:48:28PM -0700, Eric Biggers wrote:
> This series contains some cleanups and optimizations for dm-verity that
> I've split out from my multibuffer hashing series
> https://lore.kernel.org/linux-crypto/20240621165922.77672-1-ebiggers@xxxxxxxxxx/.
>
> This series does not depend on any crypto API changes, so it can be
> applied right away.
>
> Eric Biggers (7):
> dm-verity: move hash algorithm setup into its own function
> dm-verity: move data hash mismatch handling into its own function
> dm-verity: make real_digest and want_digest fixed-length
> dm-verity: provide dma_alignment limit in io_hints
> dm-verity: always "map" the data blocks
> dm-verity: make verity_hash() take dm_verity_io instead of
> ahash_request
> dm-verity: hash blocks with shash import+finup when possible
>
> drivers/md/dm-verity-fec.c | 32 +--
> drivers/md/dm-verity-fec.h | 6 +-
> drivers/md/dm-verity-target.c | 461 ++++++++++++++++------------------
> drivers/md/dm-verity.h | 39 ++-
> 4 files changed, 242 insertions(+), 296 deletions(-)

Thanks for applying this, Mikulas!

I sent out a new version of "dm-verity: provide dma_alignment limit in io_hints"
to address Christoph's comment.

Also, I noticed that when you applied the patches, patch 2 somehow ended up with
the same commit message as patch 1. Can you fix that? Thanks!

- Eric