Re: [PATCH] dm-verity: fix dm_is_verity_target() when dm-verity is builtin

[Kees Cook]

On Wed, Jul 03, 2024 at 01:08:13PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> When CONFIG_DM_VERITY=y, dm_is_verity_target() returned true for any
> builtin dm target, not just dm-verity.  Fix this by checking for
> verity_target instead of THIS_MODULE (which is NULL for builtin code).
> 
> Fixes: b6c1c5745ccc ("dm: Add verity helpers for LoadPin")
> Cc: stable@xxxxxxxxxxxxxxx
> Cc: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>

Ah! Nice catch.

Reviewed-by: Kees Cook <kees@xxxxxxxxxx>

-- 
Kees Cook