Re: [RFC PATCH] i2c: rcar: bring hardware to known state when probing

[Andi Shyti]

Hi Wolfram,

On Wed, Jul 03, 2024 at 09:12:03AM GMT, Wolfram Sang wrote:
> Probably due to a lot of refactorization, the hardware was not brought
> into a known state in probe. This may be a problem when a hypervisor
> restarts Linux without resetting the hardware, leaving an old state
> running. Make sure the hardware gets initialized, especially interrupts
> should be cleared and disabled.
> 
> Reported-by: Dirk Behme <dirk.behme@xxxxxxxxxxxx>
> Reported-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Closes: https://lore.kernel.org/r/20240702045535.2000393-1-dirk.behme@xxxxxxxxxxxx
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Do we need the Fixes tag here?

> ---
> 
> Here is my proposal to fix the issue reported by Dirk. Build tested.
> I can do proper testing on HW only tomorrow. But so you know already...

Looks reasonable. If testing is fine I can queue this up for this
week's pull request.

> It is strange to add another "_slave" function to the driver while I
> work on removing such language from I2C somewhere else. "Consistency" is
> the answer here. The driver will be converted as well. But then as a
> whole.

Ack!

Thanks,
Andi