Re: [PATCH net-next 1/9] net/sched: flower: define new tunnel flags
From: Jakub Kicinski
Date: Wed Jul 03 2024 - 20:20:49 EST
On Wed, 3 Jul 2024 12:59:54 +0200 Alexander Lobakin wrote:
> > enum {
> > TCA_FLOWER_KEY_FLAGS_IS_FRAGMENT = (1 << 0),
> > TCA_FLOWER_KEY_FLAGS_FRAG_IS_FIRST = (1 << 1),
> > + /* FLOW_DIS_ENCAPSULATION (1 << 2) is not exposed to userspace */
>
> Should uAPI header contain this comment? FLOW_DIS_ENCAPSULATION is an
> internal kernel definition, so I believe its name shouldn't leak to the
> userspace header.
Also since it's internal, can avoid the gap in uAPI and make
ENCAPSULATION be something like "last uAPI bit + 1" ?