Re: [PATCH v4 1/3] mctp pcc: Check before sending MCTP PCC response ACK

From: kernel test robot
Date: Wed Jul 03 2024 - 22:46:39 EST


Hi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on rafael-pm/bleeding-edge linus/master v6.10-rc6 next-20240703]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/admiyo-os-amperecomputing-com/mctp-pcc-Check-before-sending-MCTP-PCC-response-ACK/20240703-163558
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20240702225845.322234-2-admiyo%40os.amperecomputing.com
patch subject: [PATCH v4 1/3] mctp pcc: Check before sending MCTP PCC response ACK
config: i386-buildonly-randconfig-004-20240704 (https://download.01.org/0day-ci/archive/20240704/202407041052.926ISbwR-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Ubuntu 12.3.0-9ubuntu2) 12.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240704/202407041052.926ISbwR-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407041052.926ISbwR-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/mailbox/pcc.c:115: warning: Function parameter or struct member 'shmem_base_addr' not described in 'pcc_chan_info'


vim +115 drivers/mailbox/pcc.c

800cda7b63f22b Sudeep Holla 2021-09-17 82
80b2bdde002c52 Sudeep Holla 2021-09-17 83 /**
80b2bdde002c52 Sudeep Holla 2021-09-17 84 * struct pcc_chan_info - PCC channel specific information
80b2bdde002c52 Sudeep Holla 2021-09-17 85 *
0f2591e21b2e85 Sudeep Holla 2021-09-17 86 * @chan: PCC channel information with Shared Memory Region info
bf18123e78f4d1 Sudeep Holla 2021-09-17 87 * @db: PCC register bundle for the doorbell register
bf18123e78f4d1 Sudeep Holla 2021-09-17 88 * @plat_irq_ack: PCC register bundle for the platform interrupt acknowledge
bf18123e78f4d1 Sudeep Holla 2021-09-17 89 * register
c45ded7e11352d Sudeep Holla 2021-09-17 90 * @cmd_complete: PCC register bundle for the command complete check register
c45ded7e11352d Sudeep Holla 2021-09-17 91 * @cmd_update: PCC register bundle for the command complete update register
c45ded7e11352d Sudeep Holla 2021-09-17 92 * @error: PCC register bundle for the error status register
f92ae90e52bb09 Sudeep Holla 2021-09-17 93 * @plat_irq: platform interrupt
60c40b06fa6869 Huisong Li 2023-08-01 94 * @type: PCC subspace type
3db174e478cb0b Huisong Li 2023-08-01 95 * @plat_irq_flags: platform interrupt flags
3db174e478cb0b Huisong Li 2023-08-01 96 * @chan_in_use: this flag is used just to check if the interrupt needs
3db174e478cb0b Huisong Li 2023-08-01 97 * handling when it is shared. Since only one transfer can occur
3db174e478cb0b Huisong Li 2023-08-01 98 * at a time and mailbox takes care of locking, this flag can be
3db174e478cb0b Huisong Li 2023-08-01 99 * accessed without a lock. Note: the type only support the
3db174e478cb0b Huisong Li 2023-08-01 100 * communication from OSPM to Platform, like type3, use it, and
3db174e478cb0b Huisong Li 2023-08-01 101 * other types completely ignore it.
80b2bdde002c52 Sudeep Holla 2021-09-17 102 */
80b2bdde002c52 Sudeep Holla 2021-09-17 103 struct pcc_chan_info {
0f2591e21b2e85 Sudeep Holla 2021-09-17 104 struct pcc_mbox_chan chan;
bf18123e78f4d1 Sudeep Holla 2021-09-17 105 struct pcc_chan_reg db;
bf18123e78f4d1 Sudeep Holla 2021-09-17 106 struct pcc_chan_reg plat_irq_ack;
c45ded7e11352d Sudeep Holla 2021-09-17 107 struct pcc_chan_reg cmd_complete;
c45ded7e11352d Sudeep Holla 2021-09-17 108 struct pcc_chan_reg cmd_update;
c45ded7e11352d Sudeep Holla 2021-09-17 109 struct pcc_chan_reg error;
ddd70a454be0e5 Adam Young 2024-07-02 110 void __iomem *shmem_base_addr;
f92ae90e52bb09 Sudeep Holla 2021-09-17 111 int plat_irq;
60c40b06fa6869 Huisong Li 2023-08-01 112 u8 type;
3db174e478cb0b Huisong Li 2023-08-01 113 unsigned int plat_irq_flags;
3db174e478cb0b Huisong Li 2023-08-01 114 bool chan_in_use;
80b2bdde002c52 Sudeep Holla 2021-09-17 @115 };
80b2bdde002c52 Sudeep Holla 2021-09-17 116

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki