Re: [PATCH -next] md/raid5: fix spares errors about rcu usage

From: Song Liu
Date: Thu Jul 04 2024 - 03:06:31 EST


On Sat, Jun 15, 2024 at 4:52 PM Yu Kuai <yukuai1@xxxxxxxxxxxxxxx> wrote:
>
> From: Yu Kuai <yukuai3@xxxxxxxxxx>
>
> As commit ad8606702f26 ("md/raid5: remove rcu protection to access rdev
> from conf") explains, rcu protection can be removed, however, there are
> three places left, there won't be any real problems.
>
> drivers/md/raid5.c:8071:24: error: incompatible types in comparison expression (different address spaces):
> drivers/md/raid5.c:8071:24: struct md_rdev [noderef] __rcu *
> drivers/md/raid5.c:8071:24: struct md_rdev *
> drivers/md/raid5.c:7569:25: error: incompatible types in comparison expression (different address spaces):
> drivers/md/raid5.c:7569:25: struct md_rdev [noderef] __rcu *
> drivers/md/raid5.c:7569:25: struct md_rdev *
> drivers/md/raid5.c:7573:25: error: incompatible types in comparison expression (different address spaces):
> drivers/md/raid5.c:7573:25: struct md_rdev [noderef] __rcu *
> drivers/md/raid5.c:7573:25: struct md_rdev *
>
> Fixes: ad8606702f26 ("md/raid5: remove rcu protection to access rdev from conf")
> Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>

Applied to md-6.11. Thanks!

Song