Re: [PATCH] sched/fair: Optimize vlag entity placement

[Metin Kaya]

On 04/07/2024 10:23 am, Fernand Sieber wrote:
> Optimize for common path when placing an entity with no lag.
> Since adjusting a zero lag is always going to produce a zero lag regardless
> of the local load, don't bother about calaculating the adjusting factor.
                                        calculating

> Signed-off-by: Fernand Sieber <sieberf@xxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Juri Lelli <juri.lelli@xxxxxxxxxx>
> Cc: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> ---
>   kernel/sched/fair.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 8a5b1ae0aa55..e78272c87274 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5190,7 +5190,7 @@ place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags)
>   	 *
>   	 * EEVDF: placement strategy #1 / #2
>   	 */
> -	if (sched_feat(PLACE_LAG) && cfs_rq->nr_running) {
> +	if (se->vlag && sched_feat(PLACE_LAG) && cfs_rq->nr_running) {
>   		struct sched_entity *curr = cfs_rq->curr;
>   		unsigned long load;
>   

Thanks,