Re: [PATCH 1/3] printk: Add match_devname_and_update_preferred_console()
From: Greg Kroah-Hartman
Date: Thu Jul 04 2024 - 08:57:28 EST
On Thu, Jul 04, 2024 at 01:44:03PM +0200, Petr Mladek wrote:
> On Wed 2024-07-03 13:06:08, Tony Lindgren wrote:
> > Let's add match_devname_and_update_preferred_console() for driver
> > subsystems to call during init when the console is ready, and it's
> > character device name is known. For now, we use it only for the serial
> > layer to allow console=DEVNAME:0.0 style hardware based addressing for
> > consoles.
> >
> > The earlier attempt on doing this caused a regression with the kernel
> > command line console order as it added calling __add_preferred_console()
> > again later on during init. A better approach was suggested by Petr where
> > we add the deferred console to the console_cmdline[] and update it later
> > on when the console is ready.
> >
> > Suggested-by: Petr Mladek <pmladek@xxxxxxxx>
> > Co-developed-by: Petr Mladek <pmladek@xxxxxxxx>
> > Signed-off-by: Tony Lindgren <tony.lindgren@xxxxxxxxxxxxxxx>
>
> Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>
Thanks for the review, I'll take this through the tty tree now.
greg k-h