Re: [PATCH v2 4/4] rust: macros: Enable the rest of the tests

[Alice Ryhl]

On Thu, Jul 4, 2024 at 4:49 PM Ethan D. Twardy <ethan.twardy@xxxxxxxxx> wrote:
>
> On Thu Jul 4, 2024 at 4:43 AM CDT, Alice Ryhl wrote:
> > On Mon, Jul 1, 2024 at 1:28 PM Ethan D. Twardy <ethan.twardy@xxxxxxxxx> wrote:
> > >
> > > Now that the rusttest target for the macros crate is compiled with the
> > > kernel crate as a dependency, the rest of the rustdoc tests can be
> > > enabled.
> > >
> > > Signed-off-by: Ethan D. Twardy <ethan.twardy@xxxxxxxxx>
> >
> > I would drop the newline before `fn main()` here:
> >
> > > @@ -221,6 +248,8 @@ pub fn concat_idents(ts: TokenStream) -> TokenStream {
> > >  ///         unsafe { bindings::destroy_info(self.raw_info) };
> > >  ///     }
> > >  /// }
> > > +///
> > > +/// # fn main() {}
> > >  /// ```
>
> So close! v3 incoming :). Thank you for your review!

You're welcome :)

Unfortunately, I'm not really able to review the first patch in this series.

Alice