Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

From: Krzysztof Kozlowski
Date: Fri Jul 05 2024 - 06:00:14 EST


On 04/06/2024 15:18, Krzysztof Kozlowski wrote:
> On 27/05/2024 16:47, Alain Volmat wrote:
>> Hi Krzysztof,
>>
>> thanks for your patch, sorry for the delay.
>>
>> On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote:
>>> Core in platform_driver_register() already sets the .owner, so driver
>>> does not need to. Whatever is set here will be anyway overwritten by
>>> main driver calling platform_driver_register().
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>> ---
>>>
>>> I forgot two drivers.
>>> drivers/gpu/drm/sti/sti_hdmi.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
>>> index 500936d5743c..b0d84440a87b 100644
>>> --- a/drivers/gpu/drm/sti/sti_hdmi.c
>>> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
>>> @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev)
>>> struct platform_driver sti_hdmi_driver = {
>>> .driver = {
>>> .name = "sti-hdmi",
>>> - .owner = THIS_MODULE,
>>> .of_match_table = hdmi_of_match,
>>> },
>>> .probe = sti_hdmi_probe,
>>> --
>>> 2.34.1
>>>
>>
>> Acked-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>
>
> What does this ack mean? You are the maintainer, so what is supposed to
> happen now? If maintainer does not take patches, then the DRM STI looks
> orphaned.

+Cc Neil, Dmitry,

I pinged and pinged and wanted some sort of clarification here but one
month passed and nothing was clarified.

I could be understanding the DRM process wrong, but if no one picks up
trivial cleanups for 1.5 months, then to me subsystem is orphaned. I
will send respective MAINTAINERS update.

Best regards,
Krzysztof