Re: [PATCH v3 1/2] mm: add per-order mTHP split counters

[Barry Song]

On Fri, Jul 5, 2024 at 9:08 PM David Hildenbrand <david@xxxxxxxxxx> wrote:
>
> > @@ -3253,8 +3259,9 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list,
> >               i_mmap_unlock_read(mapping);
> >   out:
> >       xas_destroy(&xas);
> > -     if (is_thp)
> > +     if (order >= HPAGE_PMD_ORDER)
>
> We likely should be using "== HPAGE_PMD_ORDER" here, to be safe for the
> future.

I feel this might need to be separate since all other places are using
folio_test_pmd_mappable() ?

>
> Acked-by: David Hildenbrand <david@xxxxxxxxxx>
>
> --
> Cheers,
>
> David / dhildenb
>