Re: [PATCH v3 1/2] mm: add per-order mTHP split counters
From: Lance Yang
Date: Fri Jul 05 2024 - 07:31:50 EST
Hi Andrew,
Could you please fold the following changes into this patch?
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 993f0dd2a1ed..f8b5cbd4dd71 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -3266,7 +3266,7 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list,
i_mmap_unlock_read(mapping);
out:
xas_destroy(&xas);
- if (order >= HPAGE_PMD_ORDER)
+ if (order == HPAGE_PMD_ORDER)
count_vm_event(!ret ? THP_SPLIT_PAGE : THP_SPLIT_PAGE_FAILED);
count_mthp_stat(order, !ret ? MTHP_STAT_SPLIT : MTHP_STAT_SPLIT_FAILED);
return ret;
Thanks,
Lance