Re: [PATCH 2/5] block: Validate logical block size in blk_validate_limits()

[Christoph Hellwig]

On Fri, Jul 05, 2024 at 01:34:37PM +0100, John Garry wrote:
>> This should print a message.  Unfortunately we don't have the device
>> name here (for that we'd need to set it at disk/queue allocation time,
>> which will require a bit of work), but even without that it will be
>> very useful.
>
> Ok, I can print a message, like:
>
> 	pr_warn("Invalid logical block size (%d)\n", bsize);
>
> I am wary though that userspace could trigger this message from the various 
> ioctls to set the bsize.

As anything ending up here is a configuration interface, such a message
should be perfectly fine.