Re: [PATCH v2 01/20] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool

[kernel test robot]

Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/alexs-kernel-org/mm-zsmalloc-add-zpdesc-memory-descriptor-for-zswap-zpool/20240703-182314
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20240703040613.681396-2-alexs%40kernel.org
patch subject: [PATCH v2 01/20] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool
config: i386-buildonly-randconfig-004-20240705 (https://download.01.org/0day-ci/archive/20240705/202407052121.e5LTYhXc-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240705/202407052121.e5LTYhXc-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407052121.e5LTYhXc-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   In file included from mm/zsmalloc.c:65:
>> mm/zpdesc.h:48:1: error: no member named 'memcg_data' in 'page'
      48 | ZPDESC_MATCH(memcg_data, memcg_data);
         | ^            ~~~~~~~~~~
   mm/zpdesc.h:40:16: note: expanded from macro 'ZPDESC_MATCH'
      40 |         static_assert(offsetof(struct page, pg) == offsetof(struct zpdesc, zp))
         |                       ^                     ~~
   include/linux/stddef.h:16:32: note: expanded from macro 'offsetof'
      16 | #define offsetof(TYPE, MEMBER)  __builtin_offsetof(TYPE, MEMBER)
         |                                 ^                        ~~~~~~
   include/linux/build_bug.h:77:50: note: expanded from macro 'static_assert'
      77 | #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
         |                                                  ^~~~
   include/linux/build_bug.h:78:56: note: expanded from macro '__static_assert'
      78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
         |                                                        ^~~~
   In file included from mm/zsmalloc.c:65:
>> mm/zpdesc.h:48:1: error: no member named 'memcg_data' in 'zpdesc'
      48 | ZPDESC_MATCH(memcg_data, memcg_data);
         | ^                        ~~~~~~~~~~
   mm/zpdesc.h:40:45: note: expanded from macro 'ZPDESC_MATCH'
      40 |         static_assert(offsetof(struct page, pg) == offsetof(struct zpdesc, zp))
         |                                                    ^                       ~~
   include/linux/stddef.h:16:32: note: expanded from macro 'offsetof'
      16 | #define offsetof(TYPE, MEMBER)  __builtin_offsetof(TYPE, MEMBER)
         |                                 ^                        ~~~~~~
   include/linux/build_bug.h:77:50: note: expanded from macro 'static_assert'
      77 | #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
         |                                                  ^~~~
   include/linux/build_bug.h:78:56: note: expanded from macro '__static_assert'
      78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
         |                                                        ^~~~
   2 errors generated.


vim +48 mm/zpdesc.h

     9	
    10	/*
    11	 * struct zpdesc -	Memory descriptor for zpool memory, now is for zsmalloc
    12	 * @flags:		Page flags, PG_private: identifies the first component page
    13	 * @lru:		Indirectly used by page migration
    14	 * @mops:		Used by page migration
    15	 * @next:		Next zpdesc in a zspage in zsmalloc zpool
    16	 * @handle:		For huge zspage in zsmalloc zpool
    17	 * @zspage:		Pointer to zspage in zsmalloc
    18	 * @memcg_data:		Memory Control Group data.
    19	 *
    20	 * This struct overlays struct page for now. Do not modify without a good
    21	 * understanding of the issues.
    22	 */
    23	struct zpdesc {
    24		unsigned long flags;
    25		struct list_head lru;
    26		struct movable_operations *mops;
    27		union {
    28			/* Next zpdescs in a zspage in zsmalloc zpool */
    29			struct zpdesc *next;
    30			/* For huge zspage in zsmalloc zpool */
    31			unsigned long handle;
    32		};
    33		struct zspage *zspage;
    34		unsigned long _zp_pad_1;
    35	#ifdef CONFIG_SLAB_OBJ_EXT
    36		unsigned long memcg_data;
    37	#endif
    38	};
    39	#define ZPDESC_MATCH(pg, zp) \
    40		static_assert(offsetof(struct page, pg) == offsetof(struct zpdesc, zp))
    41	
    42	ZPDESC_MATCH(flags, flags);
    43	ZPDESC_MATCH(lru, lru);
    44	ZPDESC_MATCH(mapping, mops);
    45	ZPDESC_MATCH(index, next);
    46	ZPDESC_MATCH(index, handle);
    47	ZPDESC_MATCH(private, zspage);
  > 48	ZPDESC_MATCH(memcg_data, memcg_data);
    49	#undef ZPDESC_MATCH
    50	static_assert(sizeof(struct zpdesc) <= sizeof(struct page));
    51	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki