Re: [PATCH] USB: serial: add missing MODULE_DESCRIPTION() macros
From: Jeff Johnson
Date: Fri Jul 05 2024 - 10:36:33 EST
On 7/5/2024 4:35 AM, Johan Hovold wrote:
> On Tue, Jun 11, 2024 at 10:52:54AM -0700, Jeff Johnson wrote:
>> With ARCH=x86, make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/ch341.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb_debug.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/mxuport.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/navman.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/qcaux.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb-serial-simple.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/symbolserial.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
>
> I amended the commit message with the (recent) commit that added this
> W=1 warning (and dropped C=1). I also tweaked three descriptions
> slightly. End result is here:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next&id=9f4dc05107a6db3743e6b9ea4014cbdc3795682d
>
> Thanks.
>
> Johan
LGTM, thanks for the cleanup!
/jeff