Re: [PATCH v1 2/2] thermal: core: Add sanity check for polling_delay and passive_delay

From: Rafael J. Wysocki
Date: Fri Jul 05 2024 - 15:41:32 EST


On Fri, Jul 5, 2024 at 9:34 PM Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:
>
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> If polling_delay is nonzero and passive_delay is 0, the thermal zone
> will use polling except when tz->passive is nonzero, which does not make
> sense.
>
> Also if polling_delay is nonzero and passive_delay is greater than
> polling_delay, the thermal zone temperature will be updated less often
> when tz->passive is nonzero. This does not make sense either.
>
> Ensure that none of the above will happen.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

Well, the changelog is OK, but the patch is not. I'll send a v2 shortly.