Re: [PATCH net] net: bcmasp: Fix error code in probe()

[Justin Chen]

On 7/4/24 8:19 AM, Dan Carpenter wrote:
> Return an error code if bcmasp_interface_create() fails.  Don't return
> success.
>
> Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Justin Chen <justin.chen@xxxxxxxxxxxx>

> ---
>   drivers/net/ethernet/broadcom/asp2/bcmasp.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> index a806dadc4196..20c6529ec135 100644
> --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> @@ -1380,6 +1380,7 @@ static int bcmasp_probe(struct platform_device *pdev)
>   			dev_err(dev, "Cannot create eth interface %d\n", i);
>   			bcmasp_remove_intfs(priv);
>   			of_node_put(intf_node);
> +			ret = -ENOMEM;
>   			goto of_put_exit;
>   		}
>   		list_add_tail(&intf->list, &priv->intfs);

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature