Re: [PATCH] crypto: xor - fix template benchmarking

From: Herbert Xu
Date: Fri Jul 05 2024 - 20:05:07 EST


On Wed, Jun 19, 2024 at 07:31:57PM +0200, Helge Deller wrote:
>
> + t0 = ktime_get();
> + /* delay start until time has advanced */
> + do { start = ktime_get(); } while (start == t0);

Please rewrite this loop in the usual kernel coding style.

What about adding a cpu_relax() in there if ktime_get doesn't
advance? Something like

while ((start = ktime_get()) == t0)
cpu_relax();

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt