Re: [PATCH v5 03/23] lib: zstd: fix null-deref in ZSTD_createCDict_advanced2()

From: Markus Elfring
Date: Sat Jul 06 2024 - 03:25:56 EST


> ZSTD_createCDict_advanced2() must ensure that
> ZSTD_createCDict_advanced_internal() has successfully
> allocated cdict. customMalloc() may be called under
> low memory condition and may be unable to allocate
> workspace for cdict.

* Please improve such a change description with imperative wordings.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n94

* Would you like to use the term “null pointer dereference” (in the summary phrase)?


Regards,
Markus