Re: [PATCH bpf-next 2/2] selftests/bpf: amend for wrong bpf_wq_set_callback_impl signature
From: Alexei Starovoitov
Date: Sat Jul 06 2024 - 20:54:16 EST
On Fri, Jul 5, 2024 at 1:54 PM Eduard Zingerman <eddyz87@xxxxxxxxx> wrote:
>
> On Fri, 2024-07-05 at 15:44 +0200, Benjamin Tissoires wrote:
> > See the previous patch: the API was wrong, we were provided the pointer
> > to the value, not the actual struct bpf_wq *.
> >
> > Signed-off-by: Benjamin Tissoires <bentiss@xxxxxxxxxx>
> > ---
>
> Would it make sense to update one of the tests, so that it checks the
> specific value put in the map?
> E.g. extend struct elem:
>
> struct elem {
> int answer_to_the_ultimate_question;
> struct bpf_wq w;
> };
>
> And put something in there?
+1
let's tweak the selftest.
pw-bot: cr