Re: [PATCH net-next v16 13/14] net: ethtool: Add support for tsconfig command to get/set hwtstamp config

From: Simon Horman
Date: Sun Jul 07 2024 - 04:24:28 EST


On Fri, Jul 05, 2024 at 05:03:14PM +0200, Kory Maincent wrote:
> Introduce support for ETHTOOL_MSG_TSCONFIG_GET/SET ethtool netlink socket
> to read and configure hwtstamp configuration of a PHC provider. Note that
> simultaneous hwtstamp isn't supported; configuring a new one disables the
> previous setting.
>
> Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> ---
>
> Changes in v16:
> - Add a new patch to separate tsinfo into a new tsconfig command to get
> and set the hwtstamp config.
> ---
> Documentation/networking/timestamping.rst | 33 +--
> include/uapi/linux/ethtool_netlink.h | 18 ++
> net/ethtool/Makefile | 3 +-
> net/ethtool/netlink.c | 20 ++
> net/ethtool/netlink.h | 3 +
> net/ethtool/tsconfig.c | 347 ++++++++++++++++++++++++++++++
> 6 files changed, 411 insertions(+), 13 deletions(-)
>

> diff --git a/Documentation/networking/timestamping.rst b/Documentation/networking/timestamping.rst
> index 5e93cd71f99f..8b864ae33297 100644
> --- a/Documentation/networking/timestamping.rst
> +++ b/Documentation/networking/timestamping.rst
> @@ -493,8 +493,8 @@ implicitly defined. ts[0] holds a software timestamp if set, ts[1]
> is again deprecated and ts[2] holds a hardware timestamp if set.
>
>
> -3. Hardware Timestamping configuration: SIOCSHWTSTAMP and SIOCGHWTSTAMP
> -=======================================================================
> +3. Hardware Timestamping configuration: ETHTOOL_MSG_TSCONFIG_SET/GET
> +==================================================================

nit: make htmldocs flags that this title underline is too short

...