Re: [PATCH v2 3/3] i2c: rcar: minor changes to adhere to coding style

[Wolfram Sang]

On Sun, Jul 07, 2024 at 12:34:36PM +0200, Markus Elfring wrote:
> > A newline was missing and closing braces of functions do not need a
> > semicolon.
> 
> Can there be a need to offer such changes by separate update steps?

That would be too fine grained in my book.

> >  	return !!(rcar_i2c_read(priv, ICMCR) & FSCL);
> >
> > -};
> > +}
> …
> 
> How do you think about to omit any blank lines at such source code places?

Oh yes, that newline should go as well. Thanks!

Attachment: signature.asc
Description: PGP signature