Re: [PATCH 1/3] dt-bindings: power: Add power sequence for Amloigc WCN chips

[Yang Li]

Dear Krzysztof

Thanks for your immediate recovery and careful guidance.

> On 05/07/2024 13:13, Yang Li via B4 Relay wrote:
> > From: Yang Li <yang.li@xxxxxxxxxxx>
> >
> > Add binding document to introduce power sequence of
> > Amlogic WCN chips.
> >
> > Signed-off-by: Yang Li <yang.li@xxxxxxxxxxx>
> > ---
> >   .../bindings/power/amlogic,w155s2-pwrseq.yaml      | 62 ++++++++++++++++++++++
> >   1 file changed, 62 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/power/amlogic,w155s2-pwrseq.yaml b/Documentation/devicetree/bindings/power/amlogic,w155s2-pwrseq.yaml
> > new file mode 100644
> > index 000000000000..f99a775fcf9b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/amlogic,w155s2-pwrseq.yaml
> > @@ -0,0 +1,62 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/amlogic,w155s2-pwrseq.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Amlogic power sequence for WCN chips
> > +
> > +maintainers:
> > +  - Yang Li <yang.li@xxxxxxxxxxx>
> > +
> > +description:
> > +  The Amlogic WCN chip contains discrete modules for WLAN and Bluetooth. Power on
> > +  Bluetooth and Wi-Fi respectively, including chip_en pull-up and bt_en pull-up,
> > +  and generation of the 32.768KHz clock.
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - const: amlogic,w155s2-pwrseq
> > +      - items:
> > +          - enum:
> > +              - amlogic,w265s1-pwrseq
> > +              - amlogic,w265p1-pwrseq
> > +              - amlogic,w265s2-pwrseq
> > +          - const: amlogic,w155s2-pwrseq
> > +
> > +  clocks:
> > +    maxItems: 1
> > +    description: clock provided to the controller (32.768KHz)
> > +
> > +  clock-names:
> > +    items:
> > +      - const: ext_clock
> Drop _clock... or actually drop entire clock-names, not much helpful.
Got it~ will do.
> > +
> > +  amlogic,chip-enable-gpios:
> > +    maxItems: 1
> > +    description: gpio specifier used to enable chipset
> For entire chipset? Then enable-gpios
Yes, I will change "amlogic,chip-enable-gpios" to "enable-gpio"
> > +
> > +  amlogic,bt-enable-gpios:
> > +    maxItems: 1
> > +    description: gpio specifier used to enable BT
> Follow existing bindings for Qualcomm as example.

Okay, I will change "amlogic,bt-enable-gpios"to "bt-enable-gpios" follow

Qualcomm's example.

> > +
> > +required:
> > +  - compatible
> > +  - clocks
> > +  - clock-names
> > +  - amlogic,chip-enable-gpios
> > +  - amlogic,bt-enable-gpios
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +    wcn_pwrseq {
> No underscores in node names, generic node names.
>
> There is no device as "pwrseq". I also do not get what "wcn" means here.

Yes, I understand.

Can I change "wcn_pwrseq" to "pmu", and do I need to change the binding 
file name to "amlogic,w155s2-pmu"

> Best regards,
> Krzysztof