Re: [PATCH 1/3] dt-bindings: power: Add power sequence for Amloigc WCN chips

[Yang Li]

在 2024/7/8 14:11, Krzysztof Kozlowski 写道:
> [ EXTERNAL EMAIL ]
>
> On 08/07/2024 08:04, Yang Li wrote:
> > > > +
> > > > +required:
> > > > +  - compatible
> > > > +  - clocks
> > > > +  - clock-names
> > > > +  - amlogic,chip-enable-gpios
> > > > +  - amlogic,bt-enable-gpios
> > > > +
> > > > +additionalProperties: false
> > > > +
> > > > +examples:
> > > > +  - |
> > > > +    #include <dt-bindings/gpio/gpio.h>
> > > > +    wcn_pwrseq {
> > > No underscores in node names, generic node names.
> > >
> > > There is no device as "pwrseq". I also do not get what "wcn" means here.
> > Yes, I understand.
> >
> > Can I change "wcn_pwrseq" to "pmu", and do I need to change the binding
> What is pmu for your device? What is this device in the first place you
> are documenting? Where is the datasheet?

^_^ Well, You are right, the "pmu" wasn't really fit in here.

I'd like to explain the current usage first, and could you please give 
me a suggestion?

This module(pwrseq) used to power on Bluetooth & Wi-Fi combo chip, both 
Bluetooth and

Wi-Fi driver need to control "chip-en-gpios" pins, so we introduced the 
power sequence module.

What should we call it in this case?

> > file name to "amlogic,w155s2-pmu"
> Yes, compatible should also match proper device.
>
>
> Best regards,
> Krzysztof