Re: [PATCH 1/1] i3c: master: svc: Improve DAA STOP handle code logic

[Miquel Raynal]

Hi Frank,

Frank.Li@xxxxxxx wrote on Tue,  2 Jul 2024 18:31:07 -0400:

> The REQUEST_PROC_DAA command behaves differently from other commands.
> Sometimes the hardware can auto emit STOP, but in other conditions, it
> cannot.
> 
> Improves the code logic to better handle these situations.
> 
> Hardware can auto emit STOP only when the following conditions are met:
> - The previous I3C device correctly returns a PID and ACKs an I3C address.
> - A NACK is received when emitting 7E to try to get the next I3C device's
> PID.
> 
> In all other cases, a manual STOP emission is needed.
> 
> The code is changed to emit STOP when break the while loop and 'return 0'
> only when the hardware can auto emit STOP.
> 
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>

Looks sensible to me.

Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>

Thanks,
Miquèl