Re: [PATCH v6 2/2] drivers: hwmon: sophgo: Add SG2042 external hardware monitor support

[Chen Wang]

On 2024/7/8 8:53, Inochi Amaoto wrote:
> On Mon, Jul 08, 2024 at 08:25:55AM GMT, Chen Wang wrote:
> > On 2024/7/3 10:30, Inochi Amaoto wrote:
> > > SG2042 use an external MCU to provide basic hardware information
> > > and thermal sensors.
> > >
> > > Add driver support for the onboard MCU of SG2042.
> > >
> > > Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxxxx>
> > > ---
> > >    Documentation/hwmon/index.rst |   1 +
> > >    Documentation/hwmon/sgmcu.rst |  44 +++
> > >    drivers/hwmon/Kconfig         |  11 +
> > >    drivers/hwmon/Makefile        |   1 +
> > >    drivers/hwmon/sgmcu.c         | 585 ++++++++++++++++++++++++++++++++++
> > >    5 files changed, 642 insertions(+)
> > >    create mode 100644 Documentation/hwmon/sgmcu.rst
> > >    create mode 100644 drivers/hwmon/sgmcu.c
> > >
> > > diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
> > > index 03d313af469a..189626b3a055 100644
> > > --- a/Documentation/hwmon/index.rst
> > > +++ b/Documentation/hwmon/index.rst
> > > @@ -203,6 +203,7 @@ Hardware Monitoring Kernel Drivers
> > >       sch5636
> > >       scpi-hwmon
> > >       sfctemp
> > > +   sgmcu
> > This driver is for sg2042 only, right? "sgmcu" looks be general for all
> > sophgo products.
> Yes, according to sophgo, it use this mechanism for multiple products,
> so I switch to a general name.

But multiple != ALL.

[......]