Re: [PATCH] acpi video: force native for some T2 macbooks

[Hans de Goede]

Hi,

On 7/5/24 3:56 PM, Aditya Garg wrote:
> From: Orlando Chamberlain <orlandoch.dev@xxxxxxxxx>
> 
> The intel backlight is needed for these, previously users had nothing in
> /sys/class/backlight.
> 
> Signed-off-by: Orlando Chamberlain <orlandoch.dev@xxxxxxxxx>
> Signed-off-by: Aditya Garg <gargaditya08@xxxxxxxx>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans



> ---
>  drivers/acpi/video_detect.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index 442396f6ed1f..baf7264d7b94 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -513,6 +513,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>  		DMI_MATCH(DMI_PRODUCT_NAME, "iMac12,2"),
>  		},
>  	},
> +	{
> +	 .callback = video_detect_force_native,
> +	 /* Apple MacBook Air 9,1 */
> +	 .matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir9,1"),
> +		},
> +	},
>  	{
>  	 /* https://bugzilla.redhat.com/show_bug.cgi?id=1217249 */
>  	 .callback = video_detect_force_native,
> @@ -522,6 +530,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>  		DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro12,1"),
>  		},
>  	},
> +	{
> +	 .callback = video_detect_force_native,
> +	 /* Apple MacBook Pro 16,2 */
> +	 .matches = {
> +		DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro16,2"),
> +		},
> +	},
>  	{
>  	 .callback = video_detect_force_native,
>  	 /* Dell Inspiron N4010 */