Re: [PATCH 1/6] RAS: ACPI: APEI: add conditional compilation to ARM error report functions

From: Borislav Petkov
Date: Mon Jul 08 2024 - 07:33:17 EST


On Mon, Jul 08, 2024 at 01:18:10PM +0200, Mauro Carvalho Chehab wrote:
> From: Daniel Ferguson <danielf@xxxxxxxxxxxxxxxxxxxxxx>
>
> This prevents the unnecessary inclusion of ARM specific RAS error

s/This prevents/Prevent/

Avoid having "This patch" or "This commit" or "This does <bla>" in the commit
message. It is tautologically useless.

"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour."

>From Documentation/process/submitting-patches.rst

> handling routines in non-ARM platforms.

Ok, this does "something". Why does it do it?

Otherwise it won't build on other architectures or is it going to cause code
bloat or why are we doing this?

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette