Re: [PATCH net-next v2 01/10] net/sched: flower: refactor tunnel flag definitions

From: Davide Caratti
Date: Mon Jul 08 2024 - 08:13:49 EST


hello,

On Mon, Jul 8, 2024 at 1:12 PM Asbjørn Sloth Tønnesen <ast@xxxxxxxxxxx> wrote:
>

[...]

> Davide, I think David Ahern would be happy [1] if you could post a new iproute2 patch,
> since the kernel patches should preferably hit net-next this week (due to uAPI breakage).

I will send an updated patch (don't use "matches" + add missing man
page + rename keywords [1]) in the next hours.
thanks,
--
davide

[1]

> Nit: I would prefix all of these with "tun_".

"tun_" or just "tun" ? please note that each flag can have a "no"
prefix, so is it better

notuncsum
notundf
notunoam
notuncrit

or

notun_csum
notun_df
notun_oam
notun_crit

?

(I'm for not using the underscore - but I'm open to ideas: please let me know)