Re: [PATCH 2/3] riscv: dts: sophgo: add nodes for USB phy and controller
From: Krzysztof Kozlowski
Date: Mon Jul 08 2024 - 09:42:14 EST
On 08/07/2024 14:08, Yao Zi wrote:
>
> + usb_phy: usb-phy@3006000 {
> + compatible = "sophgo,cv1800-usb-phy";
> + reg = <0x3006000 0x60>, <0x3000048 0x4>;
> + reg-names = "phy", "pin";
> + clocks = <&clk CLK_APB_USB>,
> + <&clk CLK_USB_125M>,
> + <&clk CLK_USB_33K>,
> + <&clk CLK_USB_12M>;
> + clock-names = "apb", "125m", "33k", "12m";
Why are not you using dr_role property here?
Best regards,
Krzysztof