Re: [PATCH v4 09/10] dt-bindings: opp: v2-qcom-level: Update minItems for oloop-vadj & cloop-vadj

From: Rob Herring
Date: Mon Jul 08 2024 - 11:59:19 EST


On Wed, Jul 03, 2024 at 02:46:50PM +0530, Varadarajan Narayanan wrote:
> Since IPQ9574 has only one CPR thread it will specify
> only one voltage adjustment value. Hence update min items
> accordingly for oloop-vadj and cloop-vadj. Without
> constraining min items, dt_binding_check gives errors
>
> opp-table-cpr4:opp-0:qcom,opp-cloop-vadj:0: [0] is too short
> opp-table-cpr4:opp-0:qcom,opp-oloop-vadj:0: [0] is too short
>
> Failed validating 'minItems' in schema . . .
> {'maxItems': 2, 'minItems': 2}
>
> Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> ---
> v4: Fix dt_bindings_check error
> ---
> Documentation/devicetree/bindings/opp/opp-v2-qcom-level.yaml | 2 ++
> 1 file changed, 2 insertions(+)

This is going to need to be rolled into your dependency because it needs
the same fix.

>
> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-qcom-level.yaml b/Documentation/devicetree/bindings/opp/opp-v2-qcom-level.yaml
> index b203ea01b17a..1c1a9e12d57a 100644
> --- a/Documentation/devicetree/bindings/opp/opp-v2-qcom-level.yaml
> +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-level.yaml
> @@ -39,6 +39,7 @@ patternProperties:
> An array of per-thread values representing the closed-loop
> voltage adjustment value associated with this OPP node.
> $ref: /schemas/types.yaml#/definitions/int32-array
> + minItems: 1
> maxItems: 2
>
> qcom,opp-oloop-vadj:
> @@ -46,6 +47,7 @@ patternProperties:
> An array of per-thread values representing the open-loop
> voltage adjustment value associated with this OPP node.
> $ref: /schemas/types.yaml#/definitions/int32-array
> + minItems: 1
> maxItems: 2
>
> required:
> --
> 2.34.1
>