Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled

From: Mario Limonciello
Date: Mon Jul 08 2024 - 12:02:52 EST


On 7/8/2024 10:58, Bartosz Golaszewski wrote:
On Mon, Jul 8, 2024 at 5:53 PM Mario Limonciello <superm1@xxxxxxxxxx> wrote:

On 7/8/2024 10:49, Bartosz Golaszewski wrote:


If you have CONFIG_OF enabled then of_platform_populate() will go the
normal path and actually try to populate sub-nodes of the host bridge
node. If there are no OF nodes (not a device-tree system) then it will
fail.

Bart

So how about keep both patches then?

No, it doesn't make sense. If CONFIG_OF is enabled then -ENODEV is a
valid error. I was wrong to apply the previous patch as it would lead
to hiding actual errors on OF-enabled systems.

Bart

Got it; thanks.