Re: [PATCH] dt-bindings: display: bridge: ti,sn65dsi83: add burst-mode-disabled

[Krzysztof Kozlowski]

On 08/07/2024 17:18, stefano.radaelli21@xxxxxxxxx wrote:
> From: Stefano Radaelli <stefano.radaelli21@xxxxxxxxx>
> 
> It allows to disable Burst video mode
> 
> Co-developed-by: Noah J. Rosa <noahj.rosa@xxxxxxxxx>
> Signed-off-by: Noah J. Rosa <noahj.rosa@xxxxxxxxx>
> Signed-off-by: Stefano Radaelli <stefano.radaelli21@xxxxxxxxx>
> ---
>  .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml       | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> index 48a97bb3e2e0..eb9c8b6b6813 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> @@ -35,6 +35,9 @@ properties:
>    vcc-supply:
>      description: A 1.8V power supply (see regulator/regulator.yaml).
>  
> +  burst-mode-disabled:

You described the desired Linux feature or behavior, not the actual
hardware. The bindings are about the latter, so instead you need to
rephrase the property and its description to match actual hardware
capabilities/features/configuration etc.

Also: missing type, vendor prefix and never tested.

It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.

Best regards,
Krzysztof